feat(codegen): Add WithTypeTransformer#157
Merged
yevgenypats merged 21 commits intomainfrom Sep 21, 2022
Merged
Conversation
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
erezrokah
requested changes
Sep 21, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks @yevgenypats added a few comments that were discussed in the previous PR
5 tasks
87a9920 to
adbb8b9
Compare
candiduslynx
approved these changes
Sep 21, 2022
hermanschaaf
approved these changes
Sep 21, 2022
erezrokah
approved these changes
Sep 21, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [0.7.12](v0.7.11...v0.7.12) (2022-09-21) ### Features * **codegen:** Add WithTypeTransformer ([#157](#157)) ([714e5c8](714e5c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
#157 changed the behavior of printing a log message on unsupported types (like `interface`) to failing. ~~I'm not sure that's what we want as now the consumer has to skip all the interface fields to make code gen work.~~ ~~I kept the failure on custom type transformer as I believe that should be indeed a failure to generate.~~ Changed the code to explicitly specific types ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is take two of #139
Trying to get right the
WithTypeTransformerso we wont have to change it in the near future as it's heavilly used external API.I've also added error handling to all functions as we were basically ignoring all of them and printing to the screen is not the right approach catching those locally and in CI.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)