fix: NewTableFromStruct pointer to time.Time#15
Merged
yevgenypats merged 1 commit intofeat/cqv2_wipfrom Aug 25, 2022
Merged
Conversation
erezrokah
approved these changes
Aug 25, 2022
yevgenypats
added a commit
that referenced
this pull request
Aug 30, 2022
* feat: Remove connection spec * fix SourceSpec * working on destination plugin * added bunch of tests * remove limit from sdk * Added more tests * remove dead code * fix some linters * feat: Using json everywhere apart from yaml for the user We are taking a similar approach to k8s to use json internally for marshalling/unmarshalling and yaml only for using facing stuff. yaml parsers are much more complex and also have tons of vulnerabilities so we want to use json everywhere where there is a machine reading those configurations. * more work around configuration * tests working again * Implement code generation helpers * improvments to codegen * fix: dont override nil values * more fixes to base templates * more codegen improvments * feat: Support timestamp columns (#12) * Always generate path resolver (#14) * fix: NewTableFromStruct pointer to time.Time (#15) * feat: Add WithDescriptionEnabled to NewTableFromStruct I suggest not to use it as it is just duplicated bloat and it is super slow * Add table descriptions (#17) * detect duplicate columns on start * fixed golang-lint * run gci * more linting Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
I spent a few minutes trying to make it work with typecasts like before, but couldn't figure out how to get the actual interface from the reflect value after calling
Elem()to dereference the pointer. Switched to a comparison withPkgPathandNameinstead to save some time, but maybe we can revisit this again later.