Skip to content

fix: Add linux_arm64 to default build targets#1267

Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
disq:fix/add-linuxarm64-to-default-build-targets
Oct 3, 2023
Merged

fix: Add linux_arm64 to default build targets#1267
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
disq:fix/add-linuxarm64-to-default-build-targets

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Oct 3, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2023

⏱️ Benchmark results

Comparing with c53faf4

  • Glob-8 ns/op: 89.9 ⬇️ 0.34% decrease vs. c53faf4

@kodiakhq kodiakhq bot merged commit a5f46d1 into cloudquery:main Oct 3, 2023
@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Oct 3, 2023

After this is released we might want to set the targets explicitly in the plugins that use cross compile like:
https://github.com/cloudquery/cloudquery/blob/9eedc4cc6b44eb37d26c250fdefa51d2469b6558/.github/workflows/publish_plugin_to_hub_duckdb.yml
https://github.com/cloudquery/cloudquery/blob/9eedc4cc6b44eb37d26c250fdefa51d2469b6558/.github/workflows/publish_plugin_to_hub_snowflake.yml
https://github.com/cloudquery/cloudquery/blob/9eedc4cc6b44eb37d26c250fdefa51d2469b6558/.github/workflows/publish_plugin_to_hub_sqlite.yml

As linux_arm64 is excluded in Go Releaser config for those, but our own publishing workflow relies on it not being the default

@disq disq deleted the fix/add-linuxarm64-to-default-build-targets branch October 3, 2023 11:28
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 3, 2023
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 3, 2023
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 3, 2023
kodiakhq bot pushed a commit that referenced this pull request Oct 5, 2023
🤖 I have created a release *beep* *boop*
---


## [4.12.1](v4.12.0...v4.12.1) (2023-10-05)


### Bug Fixes

* Add `linux_arm64` to default build targets ([#1267](#1267)) ([a5f46d1](a5f46d1))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.11.1 ([#1264](#1264)) ([7a390f0](7a390f0))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.12.0 ([#1268](#1268)) ([16669fe](16669fe))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023
hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023
hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants