fix: Skip tables.json when packaging destinations#1238
Merged
kodiakhq[bot] merged 2 commits intomainfrom Sep 21, 2023
Merged
Conversation
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
- Coverage 48.84% 48.80% -0.04%
==========================================
Files 88 89 +1
Lines 8298 8310 +12
==========================================
+ Hits 4053 4056 +3
- Misses 3869 3877 +8
- Partials 376 377 +1
☔ View full report in Codecov by Sentry. |
disq
reviewed
Sep 21, 2023
serve/package.go
Outdated
| } | ||
| if err := s.writeTablesJSON(cmd.Context(), distPath); err != nil { | ||
| return err | ||
| if pluginType == "source" { |
Member
There was a problem hiding this comment.
Suggested change
| if pluginType == "source" { | |
| if pluginType == plugin.TypeSource { |
erezrokah
approved these changes
Sep 21, 2023
Member
|
This means the CLI should not fail if |
Contributor
Author
Right, it should skip the tables upload step. I'll update the CLI next |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.10.1](v4.10.0...v4.10.1) (2023-09-21) ### Bug Fixes * **scalar:** Don't pass typed nils in list values ([#1226](#1226)) ([7175e5a](7175e5a)) * Skip tables.json when packaging destinations ([#1238](#1238)) ([f6471e3](f6471e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 22, 2023
#### Summary Follow up to cloudquery/plugin-sdk#1238 <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
type(sourceordestination) argument to thepackagecommand, and switches the ordering of arguments bit (since we're making a breaking change to it anyway). Thetypeis written to package.json as well, and if it isdestination, we don't create atables.json.