fix: Validate spec only when connection is established#1223
Merged
kodiakhq[bot] merged 2 commits intomainfrom Sep 20, 2023
Merged
fix: Validate spec only when connection is established#1223kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
⏱️ Benchmark results
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 88 88
Lines 8262 8262
=======================================
Hits 4018 4018
Misses 3869 3869
Partials 375 375
☔ View full report in Codecov by Sentry. |
hermanschaaf
approved these changes
Sep 20, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
We could probably do with a better name for NoConnection but this works
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
🤖 I have created a release *beep* *boop* --- ## [4.9.1](v4.9.0...v4.9.1) (2023-09-20) ### Bug Fixes * Validate spec only when connection is established ([#1223](#1223)) ([59aef16](59aef16)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation generation will fail otherwise.
Follow-up for #1214