fix: Don't send migrate messages in destination v1 write#1167
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Aug 28, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 48.75% 48.71% -0.04%
==========================================
Files 87 87
Lines 8086 8080 -6
==========================================
- Hits 3942 3936 -6
Misses 3787 3787
Partials 357 357
☔ View full report in Codecov by Sentry. |
candiduslynx
approved these changes
Aug 25, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.6](v4.5.5...v4.5.6) (2023-08-28) ### Bug Fixes * Don't send migrate messages in destination v1 write ([#1167](#1167)) ([9ed543c](9ed543c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate messages are already sent in the CLI here https://github.com/cloudquery/cloudquery/blob/eab200d6944c54db5ef6d9a81b290ed6b8ddd06f/cli/cmd/sync_v2.go#L145 (during sync) and here https://github.com/cloudquery/cloudquery/blob/eab200d6944c54db5ef6d9a81b290ed6b8ddd06f/cli/cmd/migrate_v2.go#L66 (during migrate).
Without this fix, if you have a v2 source and a v3 destination
syncwill run migration twice, andsync --no-migratewill run migration onceUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)