Skip to content

fix: Fix testdata generation#1160

Merged
kodiakhq[bot] merged 4 commits intomainfrom
fix-testdata-generation
Aug 22, 2023
Merged

fix: Fix testdata generation#1160
kodiakhq[bot] merged 4 commits intomainfrom
fix-testdata-generation

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf commented Aug 22, 2023

Correctly randomize rows, and fix memdb to handle records with multiple rows correctly.

@github-actions github-actions bot added the fix label Aug 22, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2023 •
edited
Loading

⏱️ Benchmark results

  • Glob-8 ns/op: 99.33

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 43.75% and project coverage change: +0.02% 🎉

Comparison is base (2ca010f) 48.73% compared to head (855d76e) 48.76%.

❗ Current head 855d76e differs from pull request most recent head 32fa486. Consider uploading reports for the commit 32fa486 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   48.73%   48.76%   +0.02%     
==========================================
  Files          87       87              
  Lines        8068     8084      +16     
==========================================
+ Hits         3932     3942      +10     
- Misses       3778     3785       +7     
+ Partials      358      357       -1
Files Changed Coverage Δ
plugin/sort.go 0.00% <ø> (ø)
plugin/testing_upsert.go 0.00% <0.00%> (ø)
plugin/testing_write_insert.go 0.00% <0.00%> (ø)
plugin/testing_write_migrate.go 0.00% <0.00%> (ø)
schema/testdata.go 40.05% <33.33%> (+0.16%) ⬆️
internal/memdb/memdb.go 73.50% <100.00%> (+2.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hermanschaaf hermanschaaf marked this pull request as ready for review August 22, 2023 14:27
@candiduslynx candiduslynx mentioned this pull request Aug 22, 2023
Closed
@candiduslynx candiduslynx force-pushed the fix-testdata-generation branch from 7b8ac45 to 32fa486 Compare August 22, 2023 15:27
@kodiakhq kodiakhq bot merged commit f07869a into main Aug 22, 2023
@kodiakhq kodiakhq bot deleted the fix-testdata-generation branch August 22, 2023 15:45
@cq-bot cq-bot mentioned this pull request Aug 22, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 22, 2023
@cq-bot
chore(main): Release v4.5.4 (#1162)
e222269 
🤖 I have created a release *beep* *boop*
---


## [4.5.4](v4.5.3...v4.5.4) (2023-08-22)


### Bug Fixes

* Fix testdata generation ([#1160](#1160)) ([f07869a](f07869a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@candiduslynx candiduslynx mentioned this pull request Aug 23, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@candiduslynx candiduslynx candiduslynx approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hermanschaaf hermanschaaf

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hermanschaaf @candiduslynx @yevgenypats