feat: Add more metadata to tables needed for docs generation#1129
Merged
kodiakhq[bot] merged 2 commits intomainfrom Aug 8, 2023
Merged
feat: Add more metadata to tables needed for docs generation#1129kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
⏱️ Benchmark resultsComparing with 6567043
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 47.91% 48.61% +0.69%
==========================================
Files 85 85
Lines 7808 7819 +11
==========================================
+ Hits 3741 3801 +60
+ Misses 3730 3684 -46
+ Partials 337 334 -3
☔ View full report in Codecov by Sentry. |
hermanschaaf
commented
Aug 3, 2023
| type Tables []*Table | ||
|
|
||
| // This is deprecated | ||
| // Deprecated: SyncSummary is deprecated. |
Contributor
Author
There was a problem hiding this comment.
This and some other changes here were just some comment clean-up in the file to better conform to Go standards
erezrokah
approved these changes
Aug 3, 2023
disq
approved these changes
Aug 3, 2023
yevgenypats
approved these changes
Aug 8, 2023
hermanschaaf
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.0](v4.2.6...v4.3.0) (2023-08-08) ### Features * Add more metadata to tables needed for docs generation ([#1129](#1129)) ([3dbd7f3](3dbd7f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Aug 9, 2023
…2758) This seems to work, but marking as draft because without the change in cloudquery/plugin-sdk#1129 the docs will be missing some information. I also still need to update the code here to populate table relationship data based on the parent fields by walking the tree, so that this information will be correctly displayed in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds metadata fields for table titles and parent relationships, so that this information can be sent over the wire in Arrow format. We will use this in the CLI to generate markdown and json docs for source plugins.