Merged
Conversation
Contributor
Author
|
@erezrokah can you please rebase your |
reading comments from source code is super slow and this is public api which we dont want to support. The best practice/guideline should be just pointing to the original API and not duplicating go documentation to our docs.
9b8e52a to
cad4b34
Compare
hermanschaaf
approved these changes
Sep 14, 2022
erezrokah
approved these changes
Sep 15, 2022
This was referenced Sep 15, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.2...v0.6.0) (2022-09-15) ### ⚠ BREAKING CHANGES * Remove withComment for codegen (#108) ### Features * Remove withComment for codegen ([#108](#108)) ([d8a5711](d8a5711)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reading comments from source code is super slow and this is public api which we dont want to support. The best practice/guideline should be just pointing to the original API and not duplicating go documentation to our docs.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)