fix(naming): Rename SyncMessages.InsertMessage() to SyncMessages.GetInserts()#1070
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jul 4, 2023
disq:fix/naming
Merged
fix(naming): Rename SyncMessages.InsertMessage() to SyncMessages.GetInserts()#1070kodiakhq[bot] merged 2 commits intocloudquery:mainfrom disq:fix/naming
SyncMessages.InsertMessage() to SyncMessages.GetInserts()#1070kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
disq:fix/naming
Conversation
…etInserts()` Add `SyncInserts.GetRecords()` for parity with `WriteInserts`
Contributor
|
It will mean we will have to fix it everywhere afterwards :( |
yevgenypats
approved these changes
Jul 4, 2023
Member
Author
|
Not in many places though, one line per PR :) |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
🤖 I have created a release *beep* *boop* --- ## [4.8.0-rc1](v4.7.1-rc1...v4.8.0-rc1) (2023-07-05) ### Features * **transformers:** Add `Apply` to apply extra transformations ([#1069](#1069)) ([a40598e](a40598e)) ### Bug Fixes * Deterministic ordering for records returned by readAll in tests ([#1072](#1072)) ([cf7510f](cf7510f)) * Handle null-related test options ([#1074](#1074)) ([88f08ee](88f08ee)) * **naming:** Rename `SyncMessages.InsertMessage()` to `SyncMessages.GetInserts()` ([#1070](#1070)) ([ab9e768](ab9e768)) * Reset timers on flush ([#1076](#1076)) ([767327f](767327f)) * Reverse order of records in memdb ([#1075](#1075)) ([8356590](8356590)) * **scalar:** Test `AppendTime` on TimestampBuilder ([#1068](#1068)) ([888c9ee](888c9ee)) * **testdata:** Exclude only the correct type ([#1067](#1067)) ([1c72fb2](1c72fb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add
SyncInserts.GetRecords()for parity withWriteInserts