fix(types): Extensions conversion with storage#948
Merged
kodiakhq[bot] merged 5 commits intomainfrom Jun 5, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 52.30% 52.68% +0.38%
==========================================
Files 62 62
Lines 6325 6332 +7
==========================================
+ Hits 3308 3336 +28
+ Misses 2712 2691 -21
Partials 305 305
☔ View full report in Codecov by Sentry. |
⏱️ Benchmark resultsComparing with 32a0c05
|
yevgenypats
suggested changes
Jun 5, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good but can you please add a short description on what does it do / solve ?
yevgenypats
suggested changes
Jun 5, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Few minor comments/questions.
yevgenypats
approved these changes
Jun 5, 2023
yevgenypats
approved these changes
Jun 5, 2023
yevgenypats
approved these changes
Jun 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
🤖 I have created a release *beep* *boop* --- ## [3.10.3](v3.10.2...v3.10.3) (2023-06-05) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#947](#947)) ([32a0c05](32a0c05)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 6d34568 ([#944](#944)) ([f92fd66](f92fd66)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c655015 ([#946](#946)) ([4b6e3a3](4b6e3a3)) * **types:** Extensions conversion with storage ([#948](#948)) ([1132c02](1132c02)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jun 5, 2023
Requires cloudquery/plugin-sdk#948 #### Benchmarks Performed by the following command in `typeconv/ch/values` dir: ```sh go test \ -test.run=BenchmarkFromArray \ -test.bench=BenchmarkFromArray \ -test.count 10 -test.benchmem -test.benchtime 10000x ``` <details><summary>Before this update</summary> ``` goos: darwin goarch: arm64 pkg: github.com/cloudquery/cloudquery/plugins/destination/clickhouse/typeconv/ch/values BenchmarkFromArray-10 10000 465316 ns/op 508005 B/op 7044 allocs/op BenchmarkFromArray-10 10000 442365 ns/op 508002 B/op 7044 allocs/op BenchmarkFromArray-10 10000 434197 ns/op 508006 B/op 7044 allocs/op BenchmarkFromArray-10 10000 430641 ns/op 508006 B/op 7044 allocs/op BenchmarkFromArray-10 10000 406410 ns/op 507999 B/op 7044 allocs/op BenchmarkFromArray-10 10000 429302 ns/op 508002 B/op 7044 allocs/op BenchmarkFromArray-10 10000 399611 ns/op 508005 B/op 7044 allocs/op BenchmarkFromArray-10 10000 425171 ns/op 508004 B/op 7044 allocs/op BenchmarkFromArray-10 10000 423713 ns/op 508007 B/op 7044 allocs/op BenchmarkFromArray-10 10000 413656 ns/op 508006 B/op 7044 allocs/op PASS ok github.com/cloudquery/cloudquery/plugins/destination/clickhouse/typeconv/ch/values 108.016s ``` </details> <details><summary>After this update</summary> ``` goos: darwin goarch: arm64 pkg: github.com/cloudquery/cloudquery/plugins/destination/clickhouse/typeconv/ch/values BenchmarkFromArray-10 10000 326041 ns/op 235184 B/op 4512 allocs/op BenchmarkFromArray-10 10000 310762 ns/op 235187 B/op 4512 allocs/op BenchmarkFromArray-10 10000 324254 ns/op 235182 B/op 4512 allocs/op BenchmarkFromArray-10 10000 320649 ns/op 235188 B/op 4512 allocs/op BenchmarkFromArray-10 10000 326467 ns/op 235183 B/op 4512 allocs/op BenchmarkFromArray-10 10000 310552 ns/op 235189 B/op 4512 allocs/op BenchmarkFromArray-10 10000 310553 ns/op 235188 B/op 4512 allocs/op BenchmarkFromArray-10 10000 313457 ns/op 235187 B/op 4512 allocs/op BenchmarkFromArray-10 10000 327252 ns/op 235185 B/op 4512 allocs/op BenchmarkFromArray-10 10000 312083 ns/op 235188 B/op 4512 allocs/op PASS ok github.com/cloudquery/cloudquery/plugins/destination/clickhouse/typeconv/ch/values 97.273s ``` </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that we can construct a working extension array from the underlying storage.
Specifically, there should be no difference between the array constructed from storage & the one constructed from the extension builder.
Additionally, the constructed array should be intact (so that it son't panic if the underlying storage doesn't).