append from string should save some space, too

candiduslynx · candiduslynx · commit 955de6dfba2d · 2023-06-04T14:09:40.000+03:00
diff --git a/types/inet.go b/types/inet.go
@@ -25,6 +25,10 @@ func (b *InetBuilder) Append(v *net.IPNet) {
 		b.AppendNull()
 		return
 	}
+	if len(v.IP) == 0 && len(v.Mask) == 0 {
+		b.AppendEmptyValue()
+		return
+	}
 	b.ExtensionBuilder.Builder.(*array.BinaryBuilder).Append([]byte(v.String()))
 }
 
diff --git a/types/mac.go b/types/mac.go
@@ -21,6 +21,11 @@ func NewMACBuilder(builder *array.ExtensionBuilder) *MACBuilder {
 }
 
 func (b *MACBuilder) Append(v net.HardwareAddr) {
+	if len(v) == 0 || bytes.Equal(v, make(net.HardwareAddr, 6)) {
+		b.AppendEmptyValue()
+		return
+	}
+
 	b.ExtensionBuilder.Builder.(*array.BinaryBuilder).Append(v[:])
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,10 @@ func (b InetBuilder) Append(v net.IPNet) {`
`25`	`25`	`b.AppendNull()`
`26`	`26`	`return`
`27`	`27`	`}`
	`28`	`+ if len(v.IP) == 0 && len(v.Mask) == 0 {`
	`29`	`+ b.AppendEmptyValue()`
	`30`	`+ return`
	`31`	`+ }`
`28`	`32`	`b.ExtensionBuilder.Builder.(*array.BinaryBuilder).Append([]byte(v.String()))`
`29`	`33`	`}`
`30`	`34`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,11 @@ func NewMACBuilder(builder array.ExtensionBuilder) MACBuilder {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`func (b *MACBuilder) Append(v net.HardwareAddr) {`
	`24`	`+ if len(v) == 0 \|\| bytes.Equal(v, make(net.HardwareAddr, 6)) {`
	`25`	`+ b.AppendEmptyValue()`
	`26`	`+ return`
	`27`	`+ }`
	`28`	`+`
`24`	`29`	`b.ExtensionBuilder.Builder.(*array.BinaryBuilder).Append(v[:])`
`25`	`30`	`}`
`26`	`31`