fix: TablesForSpec should only return top-level tables#456
Merged
kodiakhq[bot] merged 2 commits intomainfrom Dec 5, 2022
Merged
fix: TablesForSpec should only return top-level tables#456kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
⏱️ Benchmark results
|
candiduslynx
approved these changes
Dec 2, 2022
disq
approved these changes
Dec 2, 2022
yevgenypats
approved these changes
Dec 5, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. It includes the relations in the parent table when going over the wire right?
Contributor
Author
@yevgenypats Right 👍 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
🤖 I have created a release *beep* *boop* --- ## [1.11.0](v1.10.0...v1.11.0) (2022-12-05) ### Features * Add Support for net.IP in Faker ([#445](#445)) ([2deced1](2deced1)) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 6ab00d0 ([#449](#449)) ([b981e33](b981e33)) * **deps:** Update module github.com/avast/retry-go/v4 to v4.3.1 ([#450](#450)) ([e4116f1](e4116f1)) * **deps:** Update module google.golang.org/grpc to v1.51.0 ([#451](#451)) ([538211c](538211c)) * Don't log start-and-finish of relational tables ([#459](#459)) ([4d6eeca](4d6eeca)) * Sync Metrics for Long running plugins ([#455](#455)) ([3fecc61](3fecc61)) * TablesForSpec should only return top-level tables ([#456](#456)) ([ab7ca97](ab7ca97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cloudquery/cloudquery#5294