Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.65.0
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.66.0
Choose a head ref
  • 5 commits
  • 7 files changed
  • 2 contributors

Commits on Oct 4, 2024

  1. feat: Add time.Sleep to mitigate race condition. (#1923)

    The ShuffleQueue scheduler strategy has an infrequent race condition, as
    explained by the comment:
    
    ```
    	// A race condition is possible when the last active table asynchronously
    	// queues a relation. The table finishes (calling `.Done()`) a moment
    	// before the queue receives the `.Push()`. At this point, the queue is
    	// empty and there are no active workers.
    	//
    	// A moment later, the queue receives the `.Push()` and queues a new task.
    	//
    	// This is a very infrequent case according to tests, but it happens.
    ```
    
    After many attempts at a more elegant solution, I finally yielded:
    
    ```
    time.Sleep(10 * time.Millisecond)
    ```
    
    Looks ugly, but after running the tests 300 times (so around 3000
    syncs), it works 🤷
    
    ```
    ✓ cloudquery/plugin-sdk main* $ go test ./scheduler -count=100 -run TestScheduler             ⏱ 15:04:12
    ok  	github.com/cloudquery/plugin-sdk/v4/scheduler	143.523s
    ✓ cloudquery/plugin-sdk main* $ go test ./scheduler -count=100 -run TestScheduler              ⏱ 15:06:56
    ok  	github.com/cloudquery/plugin-sdk/v4/scheduler	142.796s
    ✓ cloudquery/plugin-sdk main* $ go test ./scheduler -count=100 -run TestScheduler              ⏱ 15:09:22
    ok  	github.com/cloudquery/plugin-sdk/v4/scheduler	144.304s
    ```
    marianogappa authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    83dfcad View commit details
    Browse the repository at this point in the history
  2. chore(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.…

    …65.0 (#1922)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-sdk/v4](https://togithub.com/cloudquery/plugin-sdk) | require | minor | `v4.64.1` -> `v4.65.0` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-sdk (github.com/cloudquery/plugin-sdk/v4)</summary>
    
    ### [`v4.65.0`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v4.65.0)
    
    [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v4.64.1...v4.65.0)
    
    ##### Features
    
    -   Implement RandomQueue scheduler strategy ([#&#8203;1914](https://togithub.com/cloudquery/plugin-sdk/issues/1914)) ([af8ac87](https://togithub.com/cloudquery/plugin-sdk/commit/af8ac87178cc318d2f31cd17efc7c921d6d52e6b))
    
    ##### Bug Fixes
    
    -   Revert "fix: Error handling in StreamingBatchWriter" ([#&#8203;1918](https://togithub.com/cloudquery/plugin-sdk/issues/1918)) ([38b4bfd](https://togithub.com/cloudquery/plugin-sdk/commit/38b4bfd20e17a00d5a2c83e1d48b8b16270592ba))
    -   **tests:** WriterTestSuite.handleNulls should not overwrite columns ([#&#8203;1920](https://togithub.com/cloudquery/plugin-sdk/issues/1920)) ([08e18e2](https://togithub.com/cloudquery/plugin-sdk/commit/08e18e265dfb7e6e77c32244f56acd0f63bf4ead))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
    cq-bot authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    abfbd1b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. fix(deps): Update module google.golang.org/grpc to v1.67.1 (#1925)

    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require | patch | `v1.67.0` -> `v1.67.1` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>grpc/grpc-go (google.golang.org/grpc)</summary>
    
    ### [`v1.67.1`](https://togithub.com/grpc/grpc-go/releases/tag/v1.67.1): Release 1.67.1
    
    [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.67.0...v1.67.1)
    
    ### Bug Fixes
    
    -   transport: Fix a bug causing stream failures due to miscalculation of the flow control window in both clients and servers. ([#&#8203;7667](https://togithub.com/grpc/grpc-go/issues/7667))
    -   xds/server: Fix xDS Server memory leak. ([#&#8203;7681](https://togithub.com/grpc/grpc-go/issues/7681))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "before 3am on Saturday" (UTC), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
    cq-bot authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    5e0305d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix(deps): Update aws-sdk-go-v2 monorepo (#1926)

    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/aws/aws-sdk-go-v2](https://togithub.com/aws/aws-sdk-go-v2) | require | minor | `v1.31.0` -> `v1.32.0` |
    | [github.com/aws/aws-sdk-go-v2/config](https://togithub.com/aws/aws-sdk-go-v2) | require | patch | `v1.27.39` -> `v1.27.41` |
    | [github.com/aws/aws-sdk-go-v2/service/licensemanager](https://togithub.com/aws/aws-sdk-go-v2) | require | minor | `v1.28.3` -> `v1.29.0` |
    | [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://togithub.com/aws/aws-sdk-go-v2) | require | minor | `v1.24.3` -> `v1.25.0` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>aws/aws-sdk-go-v2 (github.com/aws/aws-sdk-go-v2)</summary>
    
    ### [`v1.32.0`](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.31.0...v1.32.0)
    
    [Compare Source](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.31.0...v1.32.0)
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "before 3am on Saturday" (UTC), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
    cq-bot authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4fc8896 View commit details
    Browse the repository at this point in the history
  2. chore(main): Release v4.66.0 (#1924)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [4.66.0](v4.65.0...v4.66.0) (2024-10-07)
    
    
    ### Features
    
    * Add time.Sleep to mitigate race condition. ([#1923](#1923)) ([83dfcad](83dfcad))
    
    
    ### Bug Fixes
    
    * **deps:** Update aws-sdk-go-v2 monorepo ([#1926](#1926)) ([4fc8896](4fc8896))
    * **deps:** Update module google.golang.org/grpc to v1.67.1 ([#1925](#1925)) ([5e0305d](5e0305d))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    14d7896 View commit details
    Browse the repository at this point in the history
Loading