Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.3
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.4
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Oct 4, 2022

  1. fix: Improve download message (#240) 

    #### Summary

<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->


<!--
Explain what problem this PR addresses
-->

---

Use the following steps to ensure your PR is ready to be reviewed

- [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md)
🧑‍🎓
- [ ] Run `go fmt` to format your code 🖊
- [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint
[here](https://golangci-lint.run/usage/install/#local-installation))
- [ ] Update or add tests 🧪
- [ ] Ensure the status checks below are successful ✅
    @yevgenypats
    yevgenypats authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7929bbb View commit details
    Browse the repository at this point in the history

  2. fix: Race condition in log streaming (#242) 

    This adds a sync.WaitGroup to ensure that we wait for all logs to finish
streaming before returning from Terminate. Otherwise, the log file might
get closed before we get to write the final lines.
    @hermanschaaf
    hermanschaaf authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    3c8242a View commit details
    Browse the repository at this point in the history

  3. chore(main): Release v0.12.4 (#241) 

    🤖 I have created a release *beep* *boop*
---


##
[0.12.4](v0.12.3...v0.12.4)
(2022-10-04)


### Bug Fixes

* Improve download message
([#240](#240))
([7929bbb](7929bbb))
* Race condition in log streaming
([#242](#242))
([3c8242a](3c8242a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
    @cq-bot
    cq-bot authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    40f7ad5 View commit details
    Browse the repository at this point in the history
Loading