Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d17b77d
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 21a7481
Choose a head ref
  • 9 commits
  • 14 files changed
  • 6 contributors

Commits on Oct 22, 2024

  1. chore(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.…

    …67.1 (#1944)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-sdk/v4](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v4.67.0` -> `v4.67.1` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-sdk (github.com/cloudquery/plugin-sdk/v4)</summary>
    
    ### [`v4.67.1`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v4.67.1)
    
    [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v4.67.0...v4.67.1)
    
    ##### Bug Fixes
    
    -   **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.28.0 ([#&#8203;1940](https://togithub.com/cloudquery/plugin-sdk/issues/1940)) ([35cf587](https://togithub.com/cloudquery/plugin-sdk/commit/35cf587f2c96d8bbadbd0b4cdb0484039a77f089))
    -   **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.24.1 ([#&#8203;1943](https://togithub.com/cloudquery/plugin-sdk/issues/1943)) ([14f44ad](https://togithub.com/cloudquery/plugin-sdk/commit/14f44adf41ba797e156378a208ec1528070d4fcd))
    -   Ensure module field exists in all log messages ([#&#8203;1941](https://togithub.com/cloudquery/plugin-sdk/issues/1941)) ([b1ca41c](https://togithub.com/cloudquery/plugin-sdk/commit/b1ca41c632069900225b556339e74fb6d2136c6c))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
    cq-bot authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    865daf3 View commit details
    Browse the repository at this point in the history
  2. feat: Add Time configtype (#1905)

    #### Summary
    
    This adds a new Time type to be used in plugin specs that can represent either fixed times or relative times. A future PR should extend the duration parsing to handle days, etc.
    
    
    ```yml
    kind: source
    spec:
      name: "orb"
      registry: "grpc"
      path: "localhost:7777"
      version: "v1.0.0"
      tables:
        ["*"]
      destinations:
        - "sqlite"
      spec:
        api_key: "${CQ_ORB_API_KEY}"
        timeframe_start: 10 days ago
        timeframe_end: "2024-09-25T03:52:40.14157935-04:00"
    ```
    
    Here `timeframe_start` and `timeframe_end` are both configtype.Time types. Using mixed relative/fixed timestamps for timeframes isn't really useful here as the relative one will be relative to the run-time of the sync but in this example having
    ```yml
    timeframe_start: 10 days ago
    timeframe_end: now
    ```
    or even omitting `timeframe_end` entirely is more useful
    ```yml
    timeframe_start: 10 days ago
    ```
    
    The plugin is free to define default like so
    ```go
    type Spec struct {
    	// TimeframeStart is the beginning of the timeframe in which to fetch cost data.
    	TimeframeStart configtype.Time `json:"timeframe_start"`
    
    	// TimeframeEnd is the beginning of the timeframe in which to fetch cost data.
    	TimeframeEnd configtype.Time `json:"timeframe_end"`
    
    	// ...
    }
    
    
    func (s *Spec) SetDefaults() {
    	if s.TimeframeStart.IsZero() {
    		s.TimeframeStart = configtype.NewRelativeTime(-1 * 365 * 24 * time.Hour)
    	}
    
    	if s.TimeframeEnd.IsZero() {
    		s.TimeframeEnd = configtype.NewRelativeTime(0)
    	}
    }
    ```
    rhino1998 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f57c3eb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fix(deps): Update module github.com/cloudquery/plugin-pb-go to v1.25.0 (

    #1946)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-pb-go](https://togithub.com/cloudquery/plugin-pb-go) | require | minor | `v1.24.1` -> `v1.25.0` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-pb-go (github.com/cloudquery/plugin-pb-go)</summary>
    
    ### [`v1.25.0`](https://togithub.com/cloudquery/plugin-pb-go/releases/tag/v1.25.0)
    
    [Compare Source](https://togithub.com/cloudquery/plugin-pb-go/compare/v1.24.1...v1.25.0)
    
    ##### Features
    
    -   Link to latest version on 404 hub downloads ([#&#8203;423](https://togithub.com/cloudquery/plugin-pb-go/issues/423)) ([b4ca098](https://togithub.com/cloudquery/plugin-pb-go/commit/b4ca09837f39311fce53d786681c6c2f55aa1115))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
    cq-bot authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b8e3e10 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fix: Flaky usage tests (#1947)

    The problem is that there is no way to know if all rows have already been processed by the time `*BatchUpdater.Close()` is called. If they have been, then `numberOfUpdates()` will return 1 less than expected, causing the flakiness.
    
    There are two ways to fix this:
    - Make sure enough time passes between calls to `Increase()` and `Close()`. A call to `runtime.Gosched()` in the test before calling close could also help, but there are no guarantees. Timing-based tests are also generally icky.
    - Keep track of whether `Close()` actually resulted in any processed rows, and adjust the expected number of updates if so. This has to advantage of working 100% reliably, eliminating the flakiness, at the cost of introducing a field only used for tests.
    
    This commit implements the second approach.
    
    This fixes cloudquery/cloudquery-issues#2367
    dcelasun authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3ed75f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. chore: BatchUpdater: Protect against unrealistic values (#1949)

    Non-empty headers always get parsed and if it's a valid Int/Uint it gets
    persisted. Including zero values.
    
    Co-authored-by: Kemal Hadimli <disq@users.noreply.github.com>
    disq and disq authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1c4e9e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. feat: Support for quota query interval header (#1948)

    The query interval is something we're introducing in the backend.
    disq authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bfce6fe View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. feat: Test MeterUsage API call on initial setup of client (#1906)

    
    
    This allows customers to validate that the credentials they are using are valid for reporting usage
    bbernays authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    78df77d View commit details
    Browse the repository at this point in the history
  2. fix: Clean up usage retry logic (#1950)

    I may have used the term "clean up" loosely.
    disq authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ca982f9 View commit details
    Browse the repository at this point in the history
  3. chore(main): Release v4.68.0 (#1945)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [4.68.0](v4.67.1...v4.68.0) (2024-10-31)
    
    
    ### Features
    
    * Add Time configtype ([#1905](#1905)) ([f57c3eb](f57c3eb))
    * Support for quota query interval header ([#1948](#1948)) ([bfce6fe](bfce6fe))
    * Test `MeterUsage` API call on initial setup of client ([#1906](#1906)) ([78df77d](78df77d))
    
    
    ### Bug Fixes
    
    * Clean up usage retry logic ([#1950](#1950)) ([ca982f9](ca982f9))
    * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.25.0 ([#1946](#1946)) ([b8e3e10](b8e3e10))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    21a7481 View commit details
    Browse the repository at this point in the history
Loading