Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3756780
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 79d7217
Choose a head ref
  • 5 commits
  • 57 files changed
  • 4 contributors

Commits on Jan 17, 2023

  1. feat: Dynamic tables and introduce proto versioning (#610)

    This introduce WithDynamicTables for source plugins to give an option for plugins to generate tables on the go, this can be useful in GA analytics, Salesforce and others where you can only get the schema and tables in runtime.
    
    Give WithDynamicTables is actually a breaking change and I didn't want to turn our code into spagetti that tries to understand in runtime which version is the client I took the opportunity to fix our protobuf structures and introduce a way for creating new versions for server in a breaking way while also serving older versions of the server so it wont affect user experience but will give us a better way to write and maintain different versions and eventually deprecate older versions.
    
    cc @erezrokah as I know you suggested exactly that a while back but it was too early for me after the initial refactor :) and wasn't sure what are the requirements yet but here we go!
    yevgenypats authored Jan 17, 2023
    1 Configuration menu
    Copy the full SHA
    448232c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. fix: Simplify client naming conventions (#617)

    Import paths and references will need to be updated after #610 anyway, let's use this opportunity to change from e.g. `destination.WithDestinationLogger(log.Logger)` to `destination.WithLogger(log.Logger)`
    
    ~I will update the tests momentarily...~ done
    hermanschaaf authored Jan 18, 2023
    1 Configuration menu
    Copy the full SHA
    38b136b View commit details
    Browse the repository at this point in the history
  2. fix(clients): Update log line too long message (#611)

    
    Fixes cloudquery/cloudquery#5665, by making this log message look less like an error.
    I could go with `Warn` too and maybe update the level of the other errors here (but won't do it unless someone finds those confusing).
    
    The current message can cause users to think that there is data loss or something wrong with the sync
    
    ---
    erezrokah authored Jan 18, 2023
    1 Configuration menu
    Copy the full SHA
    0d3ff48 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. feat: Add version discovery service (#619)

    This adds discovery service to support multiple versions. Follow-up to this: #610
    yevgenypats authored Jan 23, 2023
    1 Configuration menu
    Copy the full SHA
    33ab32a View commit details
    Browse the repository at this point in the history
  2. chore(main): Release v1.28.0 (#615)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [1.28.0](v1.27.0...v1.28.0) (2023-01-23)
    
    
    ### Features
    
    * Add version discovery service ([#619](#619)) ([33ab32a](33ab32a))
    * Dynamic tables and introduce proto versioning ([#610](#610)) ([448232c](448232c))
    
    
    ### Bug Fixes
    
    * **clients:** Update `log line too long` message ([#611](#611)) ([0d3ff48](0d3ff48))
    * Simplify client naming conventions ([#617](#617)) ([38b136b](38b136b))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Jan 23, 2023
    1 Configuration menu
    Copy the full SHA
    79d7217 View commit details
    Browse the repository at this point in the history
Loading