Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0042973
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7903675
Choose a head ref
  • 4 commits
  • 19 files changed
  • 4 contributors

Commits on Oct 9, 2022

  1. fix: Add custom log reader implementation to fix hang on long log lin…

    …es (#263)
    
    This fixes an issue where the CLI would hang indefinitely when it encountered a log line from a plugin that was longer than the buffer size allowed for by `bufio.Scanner`. The fix uses a wrapper around `bufio.NewReader` to skip lines that are too long to be parsed, printing an error in the log with the first 1000 characters to help with identification.
    hermanschaaf authored Oct 9, 2022
    Configuration menu
    Copy the full SHA
    f8ca238 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. feat!: Support table_concurrency and resource_concurrency (#268)

    #### Summary
    
    Closes cloudquery/cloudquery#2313 cloudquery/cloudquery#159 #264
    
    This renames `concurrency` to `table_concurrency` (this has the same behaviour as previously but the name was too generic).
    
    Also this introduce a new option `resource_concurrency` - this limits the number of go routines that resolve a specific resource (useful when a lot of column resolvers that have api calls and `PreResourceResolver`).
    
    Importe Note: both options are only for top-level concurrency control i.e we only spawn go-routines for parent tables and for resources of parent table. The reason for that is that there is no concurrency model that can work with one variable for recursive calls otherwise it will get deadlock.
    
    So right now the SDK will support only for one level - in the future if we want to support additional level we can do `table_concurrency_1` and `resource_concurrency_1` but I think for now we can skip this.
    yevgenypats authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7717d6f View commit details
    Browse the repository at this point in the history
  2. fix: DeleteStale feature (#269)

    #### Summary
    
    <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->
    testing matrix (two syncs, different versions for first and second sync
    )
    
    ![image](https://user-images.githubusercontent.com/37939765/194821929-155f2b6c-6862-4e36-9036-eb2d2d6299fc.png)
    
    <!--
    Explain what problem this PR addresses
    -->
    
    ---
    
    Use the following steps to ensure your PR is ready to be reviewed
    
    - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md)
    🧑‍🎓
    - [ ] Run `go fmt` to format your code 🖊
    - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint
    [here](https://golangci-lint.run/usage/install/#local-installation))
    - [ ] Update or add tests 🧪
    - [ ] Ensure the status checks below are successful ✅
    shimonp21 authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    837c5f3 View commit details
    Browse the repository at this point in the history
  3. chore(main): Release v0.13.0 (#267)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [0.13.0](v0.12.10...v0.13.0)
    (2022-10-10)
    
    
    ### ⚠ BREAKING CHANGES
    
    * Support table_concurrency and resource_concurrency (#268)
    
    ### Features
    
    * Support table_concurrency and resource_concurrency
    ([#268](#268))
    ([7717d6f](7717d6f))
    
    
    ### Bug Fixes
    
    * Add custom log reader implementation to fix hang on long log lines
    ([#263](#263))
    ([f8ca238](f8ca238))
    * DeleteStale feature
    ([#269](#269))
    ([837c5f3](837c5f3))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7903675 View commit details
    Browse the repository at this point in the history
Loading