feat: Expose ConnectionString method in Client#57
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jul 3, 2023
Merged
Conversation
yevgenypats
reviewed
Jul 3, 2023
| case RegistryLocal: | ||
| return "unix://" + tgt | ||
| case RegistryGithub: | ||
| return "unix://" + tgt |
Contributor
There was a problem hiding this comment.
where you able to test it? that it works on connection creation? I don't remember if it's unix:// or unix:///
Member
Author
There was a problem hiding this comment.
I tested the unix one yeah, haven't tested grpc:// yet, let me do that now
Member
Author
There was a problem hiding this comment.
yeah actually grpc:// doesn't work, it says too many colons in address...
Member
Author
There was a problem hiding this comment.
Ok fixed. In the grpc:// case it should have no prefix, unix:// is treated as a special value by the Go GRPC client.
yevgenypats
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes a
ConnectionStringmethod that can be used to connect to the client via GRPC. It includes the protocol in the string so that GRPC clients can automatically infer the connection type.