Conversation
5 tasks
a689b18 to
d5b4285
Compare
Member
Author
|
Once cloudquery/plugin-pb#26 is merged this PR will get autogenerated so we will be able to close this one |
Member
Author
|
Done in #407 |
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Sep 18, 2024
#### Summary Goes with cloudquery/plugin-pb-go#401. ~~Still testing this so in draft~~ Part of cloudquery/cloudquery-issues#2214 (internal issue) ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-pb#26
Still testing this so in draftUse the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)