Skip to content

fix: SpecReader should escape external JSON content from files and environment variables#4

Merged
kodiakhq[bot] merged 3 commits intomainfrom
fix/specreader-escape-json-embeds
Jun 5, 2023
Merged

fix: SpecReader should escape external JSON content from files and environment variables#4
kodiakhq[bot] merged 3 commits intomainfrom
fix/specreader-escape-json-embeds

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented May 30, 2023

Should fix #9094

Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@disq disq force-pushed the fix/specreader-escape-json-embeds branch from 2a17dac to d7a3e8a Compare June 1, 2023 09:50
@disq
Copy link
Copy Markdown
Member Author

disq commented Jun 5, 2023

This also solves cloudquery/cloudquery#10987 now.

@disq disq requested a review from erezrokah June 5, 2023 16:47
@disq disq changed the title fix: SpecReader to escape embedded JSON files fix: SpecReader should escape external JSON content from files and environment variables Jun 5, 2023
@github-actions github-actions bot added fix and removed fix labels Jun 5, 2023
@disq disq added the automerge Add to automerge PRs once requirements are met label Jun 5, 2023
@kodiakhq kodiakhq bot merged commit 54b172f into main Jun 5, 2023
@kodiakhq kodiakhq bot deleted the fix/specreader-escape-json-embeds branch June 5, 2023 17:22
@cq-bot cq-bot mentioned this pull request Jun 5, 2023
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


## [1.0.9](v1.0.8...v1.0.9) (2023-06-06)


### Bug Fixes

* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#6](#6)) ([bbf4975](bbf4975))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#7](#7)) ([ead0d7f](ead0d7f))
* **deps:** Update google.golang.org/genproto/googleapis/rpc digest to e85fd2c ([#11](#11)) ([e21aa76](e21aa76))
* **deps:** Update module github.com/davecgh/go-spew to v1.1.1 ([#9](#9)) ([a6a34f4](a6a34f4))
* **deps:** Update module github.com/stretchr/testify to v1.8.4 ([#12](#12)) ([dba4977](dba4977))
* Embedded content handling with newlines ([#13](#13)) ([ceb6046](ceb6046))
* SpecReader should escape external JSON content from files and environment variables ([#4](#4)) ([54b172f](54b172f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to automerge PRs once requirements are met fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON string substitution with env variable is inserting double quote. bug: File Substitution For JSON

3 participants