Conversation
2 tasks
erezrokah
approved these changes
Jun 6, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, but I think we can skip the major bump. Don't think anything else is using this API other than the CLI, and if we do an major bump we need to update all improves and the version in go.mod
candiduslynx
suggested changes
Jun 6, 2024
candiduslynx
approved these changes
Jun 6, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.19.19](v1.19.18...v1.19.19) (2024-06-06) ### Bug Fixes * Progressbar handling ([#336](#336)) ([538487d](538487d)) * Revert "fix(deps): Update module github.com/schollz/progressbar/v3 to v3.14.3 ([#330](#330))" ([#338](#338)) ([74429d5](74429d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jun 6, 2024
) Goes with cloudquery/plugin-pb-go#336 ~needs cloudquery/plugin-pb-go#337 released~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to skip using progressbar. Since the new progressbar release, writing to the progressbar where the target writer is closed (in our case,
os.Stdout) produces an error.