fix: Print version in error after @, not before#325
Merged
kodiakhq[bot] merged 1 commit intomainfrom May 24, 2024
Merged
Conversation
2ee249b to
3664740
Compare
erezrokah
commented
May 24, 2024
| return false, fmt.Errorf("failed to get %s plugin (name: %s/%s@%s) information: %s", cloudquery_api.PluginKind(ops.PluginKind), ops.PluginTeam, ops.PluginName, ops.PluginVersion, p.Status()) | ||
| } | ||
| if p.JSON200 == nil { | ||
| return false, fmt.Errorf("failed to get %s plugin (name: %s/%s@%s) information: response body is empty", cloudquery_api.PluginKind(ops.PluginKind), ops.PluginVersion, ops.PluginTeam, ops.PluginName) |
Member
Author
There was a problem hiding this comment.
Here the version was printed instead of the team
candiduslynx
approved these changes
May 24, 2024
bbernays
approved these changes
May 24, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 24, 2024
🤖 I have created a release *beep* *boop* --- ## [1.19.17](v1.19.16...v1.19.17) (2024-05-24) ### Bug Fixes * Print version in error after `@`, not before ([#325](#325)) ([9c40790](9c40790)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #323, @bbernays let me know if I missed anything with this
Use the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)