feat: Expose Parquet version and root repetition spec options #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Testing this via cloudquery/cloudquery#18906 |
marianogappa
approved these changes
Aug 9, 2024
Member
Author
Waiting on a confirmation from a customer before merging this PR |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.0](v4.2.29...v4.3.0) (2024-08-12) ### Features * Expose Parquet version and root repetition spec options ([#567](#567)) ([0bf397a](0bf397a)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.52.0 ([#553](#553)) ([3cca631](3cca631)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.52.1 ([#555](#555)) ([05b8e04](05b8e04)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.53.0 ([#556](#556)) ([6bad604](6bad604)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.53.1 ([#557](#557)) ([f56a85a](f56a85a)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.54.0 ([#558](#558)) ([1a445ed](1a445ed)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.55.0 ([#559](#559)) ([45062c2](45062c2)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.56.0 ([#560](#560)) ([a541223](a541223)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.0 ([#561](#561)) ([af0b62c](af0b62c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.1 ([#563](#563)) ([8acda3f](8acda3f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.0 ([#564](#564)) ([e433f6b](e433f6b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.1 ([#565](#565)) ([7a8b701](7a8b701)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.59.0 ([#566](#566)) ([26c4fa0](26c4fa0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Aug 13, 2024
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Aug 13, 2024
#### Summary Fixes cloudquery/cloudquery-issues#2106. Documents the new Parquet options added via #18917 and cloudquery/filetypes#567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some old parquet readers like Snowflake imported need the root repetition to be undefined, and they also only support Parquet v1.
This PR exposes both options.
Related to https://github.com/cloudquery/cloudquery-issues/issues/2106 (internal issue)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)