This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Merged
Conversation
disq
commented
Jun 13, 2022
roneli
reviewed
Jun 15, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Looking good, didn't approve as this is a draft, added some of my thoughts, tell me what you think :)
6bfb801 to
7949b66
Compare
roneli
reviewed
Jun 16, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Looks good, obviously not finished, but didn't have much comments one nit. yaml.Node is a great solution.
yevgenypats
reviewed
Jun 16, 2022
yevgenypats
approved these changes
Jun 16, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. just had one question/clarification.
yevgenypats
reviewed
Jun 17, 2022
roneli
approved these changes
Jun 19, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM, no further comments :)
a3654e7 to
0dcdd27
Compare
Member
Author
|
|
This way it's possible to maintain comments coming in from the provider.Example()
This reverts commit 10cf9e9.
This was referenced Jun 21, 2022
kodiakhq bot
pushed a commit
to cloudquery/cq-provider-azure
that referenced
this pull request
Jun 22, 2022
to go with cloudquery/cq-provider-sdk#332 and cloudquery/cloudquery#887 `go run main.go init azure --config config.yml` creates this: ```yaml cloudquery: providers: - name: azure version: latest connection: type: postgres username: postgres password: pass host: localhost port: 5432 database: postgres sslmode: disable providers: # provider configurations - name: azure # Optional. if you not specified, cloudquery tries to access all subscriptions available to tenant # subscriptions: # - <YOUR_SUBSCRIPTION_ID_HERE> # # list of resources to fetch resources: - account.locations - authorization.role_assignments #... ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.