Skip to content
This repository was archived by the owner on Aug 16, 2022. It is now read-only.

feat: YAML config support#352

Merged
erezrokah merged 8 commits intomainfrom
feat/yaml-support
Jun 22, 2022
Merged

feat: YAML config support#352
erezrokah merged 8 commits intomainfrom
feat/yaml-support

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Jun 20, 2022

to go with cloudquery/cq-provider-sdk and cloudquery/cloudquery#887

go run main.go init gcp --config config.yml creates this:

cloudquery:
    providers:
        - name: gcp
          version: latest
    connection:
        type: postgres
        username: postgres
        password: pass
        host: localhost
        port: 5432
        database: postgres
        sslmode: disable
providers:
    # provider configurations
    - name: gcp
      # Optional. List of folders to get projects from. Required permission: resourcemanager.projects.list
      # folder_ids:
      #   - "organizations/<ORG_ID>"
      #   - "folders/<FOLDER_ID>"
      # Optional. Maximum level of folders to recurse into
      # folders_max_depth: 5
      # Optional. If not specified either using all projects accessible.
      # project_ids:
      #   - "<CHANGE_THIS_TO_YOUR_PROJECT_ID>"
      # Optional. ServiceAccountKeyJSON passed as value instead of a file path, can be passed also via env: CQ_SERVICE_ACCOUNT_KEY_JSON
      # service_account_key_json: <YOUR_JSON_SERVICE_ACCOUNT_KEY_DATA>
      # Optional. GRPC Retry/backoff configuration, time units in seconds. Documented in https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md
      # backoff_base_delay: 1
      # backoff_multiplier: 1.6
      # backoff_max_delay: 120
      # backoff_jitter: 0.2
      # backoff_min_connect_timeout = 0
      # Optional. Max amount of retries for retrier, defaults to max 3 retries.
      # max_retries: 3
      #  
      # list of resources to fetch
      resources:
        - bigquery.datasets
        - cloudbilling.accounts
#...

@disq disq requested review from a team, irmatov and roneli and removed request for a team June 20, 2022 14:05
@roneli
Copy link
Copy Markdown
Contributor

roneli commented Jun 20, 2022

feat!

Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit make it feat! so it will change major version

@disq disq changed the title feat: YAML config support feat!: YAML config support Jun 20, 2022
@disq disq changed the title feat!: YAML config support feat: YAML config support Jun 20, 2022
@disq
Copy link
Copy Markdown
Member Author

disq commented Jun 20, 2022

it's compatible config-wise so I don't think a major version is warranted. same goes for all other provider updates (aws, test so far)

@roneli
Copy link
Copy Markdown
Contributor

roneli commented Jun 20, 2022

Fair enough, merge away ^^

@erezrokah erezrokah merged commit 23ddfb4 into main Jun 22, 2022
@erezrokah erezrokah deleted the feat/yaml-support branch June 22, 2022 11:20
kodiakhq bot pushed a commit that referenced this pull request Jun 22, 2022
🤖 I have created a release *beep* *boop*
---


## [0.8.15](v0.8.14...v0.8.15) (2022-06-22)


### Features

* YAML config support ([#352](#352)) ([23ddfb4](23ddfb4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants