This repository was archived by the owner on Aug 16, 2022. It is now read-only.
Conversation
Contributor
|
feat! |
roneli
approved these changes
Jun 20, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM, minor nit make it feat! so it will change major version
Member
Author
|
it's compatible config-wise so I don't think a major version is warranted. same goes for all other provider updates (aws, test so far) |
Contributor
|
Fair enough, merge away ^^ |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
🤖 I have created a release *beep* *boop* --- ## [0.8.15](v0.8.14...v0.8.15) (2022-06-22) ### Features * YAML config support ([#352](#352)) ([23ddfb4](23ddfb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to go with cloudquery/cq-provider-sdk and cloudquery/cloudquery#887
go run main.go init gcp --config config.ymlcreates this: