feat: Moving configuration and auth logic#37
Merged
kodiakhq[bot] merged 5 commits intomainfrom Oct 17, 2023
Merged
Conversation
969a6a2 to
b3bbc69
Compare
This is being moged from cloudquery/cli to allow it to be shared by both the `plugin-sdk` and `cloudquery/cli` components. fixes: cloudquery/cloudquery-issues#668
b3bbc69 to
f1309cf
Compare
f1309cf to
a6df06a
Compare
disq
reviewed
Oct 17, 2023
| @@ -0,0 +1,8 @@ | |||
| .PHONY: test | |||
| test: | |||
| go test -tags=assert -race ./... | |||
Member
There was a problem hiding this comment.
-tags=assert is for Arrow tests, we don't need this I think... just fyi :) (still it could be beneficial to keep it...)
Contributor
Author
There was a problem hiding this comment.
Ah, I wasn't quite sure what that was for. Good to know.
Contributor
There was a problem hiding this comment.
Yeah good call, let's remove it :)
Contributor
Author
There was a problem hiding this comment.
Sorry, missed the request - follow up here
hermanschaaf
approved these changes
Oct 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.9...v1.3.0) (2023-10-17) ### Features * Moving configuration and auth logic ([#37](#37)) ([0bffdb2](0bffdb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is being moved from cloudquery/cli to allow it to be shared by both the
plugin-sdkandcloudquery/clicomponents.This may not be the best place for this code in the long run, but for now we want to share the code between
cloudquery/cliandplugin-sdkwithout havingcloudquery/cliintroduce a dependency on theplugin-sdk.This PR also modifies the token issuing logic, to only refresh the ID token if the existing token is close to expiry. This is to minimise the API calls needed during the sync upsert process.