fix(s3): Use the correct path for test file #8939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand the code used the plugins path (i.e. cloudquery/s3). That means it doesn't actually test the correct permissions. It should use the output path that is provided by the user.
Contributor
candiduslynx
approved these changes
Mar 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.1](plugins-destination-s3-v3.0.0...plugins-destination-s3-v3.0.1) (2023-03-14) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.17.6 ([#8882](#8882)) ([5fa0031](5fa0031)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.16 ([#8883](#8883)) ([82ffe4d](82ffe4d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/ec2/imds to v1.12.24 ([#8885](#8885)) ([674fec4](674fec4)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.56 ([#8886](#8886)) ([8a3db4b](8a3db4b)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/ini to v1.3.31 ([#8889](#8889)) ([f8fdb07](f8fdb07)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/v4a to v1.0.22 ([#8890](#8890)) ([3c5b412](3c5b412)) * Use the correct path for test file ([#8939](#8939)) ([8e4be40](8e4be40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the S3 destination plugin, cloudquery failed with an Access Denied error around the test file despite correct permissions.
Beforehand the code used the plugins path (i.e. cloudquery/s3). That means it doesn't actually test the correct permissions. It should use the output path that is provided by the user.