Skip to content

feat(deps): Update MongoDB plugin-sdk to v1.38.2 #8323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Feb 21, 2023
Merged

feat(deps): Update MongoDB plugin-sdk to v1.38.2 #8323

kodiakhq merged 2 commits into from
Feb 21, 2023

Conversation

@erezrokah
Copy link
Member

@erezrokah erezrokah commented Feb 21, 2023

Summary

Updates MongoDB to the new SDK with the following issues discovered in the tests:

  • In overwrite mode, for a table with no PKs we used an empty filter always overwriting. The fix is similar to feat(deps): Update Elasticsearch plugin-sdk to v1.38.2 #8259 to use all columns as the filter
  • When reading timestamp the Go lib uses local timezone. We want to read it as UTC (assuming it's written as UTC).

@erezrokah erezrokah requested review from a team and shimonp21 and removed request for a team February 21, 2023 15:39
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Feb 21, 2023
@cq-bot cq-bot added the mongodb label Feb 21, 2023
@erezrokah erezrokah requested review from yevgenypats and removed request for shimonp21 February 21, 2023 15:39
@kodiakhq kodiakhq bot merged commit 23bb6c3 into cloudquery:main Feb 21, 2023
@cq-bot cq-bot mentioned this pull request Feb 21, 2023
Merged
@erezrokah erezrokah deleted the feat/update_mongodb_sdk branch February 21, 2023 16:07
kodiakhq bot pushed a commit that referenced this pull request Feb 21, 2023
@cq-bot
chore(main): Release plugins-destination-mongodb v1.1.0 (#8324)
e728873 
🤖 I have created a release *beep* *boop*
---


## [1.1.0](plugins-destination-mongodb-v1.0.11...plugins-destination-mongodb-v1.1.0) (2023-02-21)


### Features

* **deps:** Update MongoDB plugin-sdk to v1.38.2 ([#8323](#8323)) ([23bb6c3](23bb6c3))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah mentioned this pull request Feb 21, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Feb 23, 2023
@erezrokah
feat(deps): Update Neo4j plugin-sdk to v1.39.1 (#8330)
49715d9 

#### Summary

Required the same PK fix as MongoDB and Elasticsearch, see #8323

<!--
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erezrokah @disq @cq-bot