fix(destination-file): Update to new filetypes modules #7466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
reviewed
Jan 31, 2023
Comment on lines
22
to
26
| CSVTransformer csv.Transformer | ||
| CSVReverseTransformer csv.ReverseTransformer | ||
| JSONClient *json.Client | ||
| JSONTransformer json.Transformer | ||
| JSONReverseTransformer json.ReverseTransformer |
Collaborator
There was a problem hiding this comment.
Is there a reason why you needed to change the transformers?
Member
Author
There was a problem hiding this comment.
Nice catch, no need to do it, left over from the old PR. Fixed in 2b3a8be
bc2b4b4 to
2b3a8be
Compare
bbernays
approved these changes
Jan 31, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-destination-file-v1.0.7...plugins-destination-file-v1.1.0) (2023-02-07) ### Features * **destination-file:** Support Parquet format ([#7612](#7612)) ([c62438f](c62438f)) ### Bug Fixes * **deps:** Update google.golang.org/genproto digest to 1c01626 ([#7533](#7533)) ([c549c27](c549c27)) * **deps:** Update module github.com/cloudquery/filetypes to v1.3.2 ([#7598](#7598)) ([0a7a1a8](0a7a1a8)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.1 ([#7614](#7614)) ([2fe665c](2fe665c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#7719](#7719)) ([6a33085](6a33085)) * **destination-file:** Update to new filetypes modules ([#7466](#7466)) ([d2aaa33](d2aaa33)) * **destinations:** Unmarshal spec error messages ([#7463](#7463)) ([85450ad](85450ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #7456