Skip to content

fix(azure)!: Add subscription_id to azure_reservations_reservation PK #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 4 commits into from
Jan 27, 2023
Merged

fix(azure)!: Add subscription_id to azure_reservations_reservation PK #7284

kodiakhq merged 4 commits into from
Jan 27, 2023

Conversation

@candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Jan 27, 2023 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
chore: PR was reverted
END_COMMIT_OVERRIDE

@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Jan 27, 2023
@candiduslynx candiduslynx requested a review from disq January 27, 2023 15:30
@cq-bot cq-bot added the azure label Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Jan 27, 2023

This PR has the following changes to source plugin(s) tables:

  • Table azure_reservations_reservation: primary key constraint added to column subscription_id

@candiduslynx
Copy link
Contributor Author

candiduslynx commented Jan 27, 2023

Given that the id should've been quite unique already, the feasible option is to add subscription id as well

@kodiakhq kodiakhq bot merged commit 852f4c1 into main Jan 27, 2023
@kodiakhq kodiakhq bot deleted the fix/azure/pk/azure_reservations_reservation branch January 27, 2023 16:15
@cq-bot cq-bot mentioned this pull request Jan 27, 2023
Merged
@erezrokah
Copy link
Member

erezrokah commented Jan 29, 2023

I'm not sure this is the correct fix (though it does solve the issue).
This API does not require passing a subscription so the duplicate keys were probably due to us multiplexing over those.
I think the fix should be to drop the multiplexer and the subscription id column, see:

cloudquery/plugins/source/azure/resources/services/reservations/reservation.go

Line 25 in 729f0fa

svc, err := armreservations.NewReservationClient(cl.Creds, cl.Options)

This was referenced Jan 30, 2023
Closed
Merged
kodiakhq bot pushed a commit that referenced this pull request Jan 30, 2023
@candiduslynx
fix(azure)!: Drop subscription_id from `azure_reservations_reservat…
daf7249 
…ion` (#7345)

Related to #7284.
Fixes #7254.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@erezrokah erezrokah Awaiting requested review from erezrokah

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@candiduslynx @erezrokah @disq @cq-bot