Skip to content

fix(aws): Add PKs To IAM Resources#6741

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
bbernays:add-pks
Jan 11, 2023
Merged

fix(aws): Add PKs To IAM Resources#6741
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
bbernays:add-pks

Conversation

@bbernays
Copy link
Copy Markdown
Collaborator

@bbernays bbernays commented Jan 11, 2023

Summary

@bbernays bbernays linked an issue Jan 11, 2023 that may be closed by this pull request
Bug(Neo4j): Neo4j Syncs append data into certain tables #6377
Closed
@cq-bot cq-bot added the aws label Jan 11, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

This PR has the following changes to source plugin(s) tables:

  • Table aws_iam_role_policies: primary key constraint added to column account_id
  • Table aws_iam_role_policies: primary key constraint added to column policy_name
  • Table aws_iam_role_policies: primary key constraint added to column role_arn
  • Table aws_iam_role_policies: primary key constraint removed from column _cq_id
  • Table aws_iam_user_access_keys: primary key constraint added to column access_key_id
  • Table aws_iam_user_access_keys: primary key constraint added to column account_id
  • Table aws_iam_user_access_keys: primary key constraint added to column user_arn
  • Table aws_iam_user_access_keys: primary key constraint removed from column _cq_id
  • Table aws_iam_user_attached_policies: column order changed for policy_arn
  • Table aws_iam_user_attached_policies: primary key constraint added to column account_id
  • Table aws_iam_user_attached_policies: primary key constraint added to column policy_name
  • Table aws_iam_user_attached_policies: primary key constraint added to column user_arn
  • Table aws_iam_user_attached_policies: primary key constraint removed from column _cq_id

candiduslynx
candiduslynx approved these changes Jan 11, 2023
View reviewed changes
plugins/source/aws/docs/tables/aws_iam_user_access_keys.md
# Table: aws_iam_user_access_keys

The primary key for this table is **_cq_id**.
The composite primary key for this table is (**account_id**, **user_arn**, **access_key_id**).
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it be just access key id?

Copy link
Copy Markdown
Collaborator Author

@bbernays bbernays Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anywhere that states the access_key_id is globally unique... If you can I am happy to change it to be just that

@bbernays bbernays added the automerge Automatically merge once required checks pass label Jan 11, 2023
@kodiakhq kodiakhq bot merged commit f7cdb07 into cloudquery:main Jan 11, 2023
@cq-bot cq-bot mentioned this pull request Jan 11, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Jan 12, 2023
@cq-bot
chore(main): Release plugins-source-aws v11.0.0 (#6679)
b11670e 
🤖 I have created a release *beep* *boop*
---


## [11.0.0](plugins-source-aws-v10.1.0...plugins-source-aws-v11.0.0) (2023-01-12)


### ⚠ BREAKING CHANGES

* introduce `aws_s3_bucket_grants` explicit primary key `(bucket_arn, grantee_id)`. If you've previously synced this table you'll need to drop it for the PK change (migration) to succeed.

### Features

* **aws:** Add Org resource policies ([#6743](#6743)) ([80dcf8e](80dcf8e))
* **aws:** Add support for xray resource policy ([#4833](#4833)) ([b68dc35](b68dc35))


### Bug Fixes

* **aws:** Add PKs To IAM Resources ([#6741](#6741)) ([f7cdb07](f7cdb07))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.2 ([#6695](#6695)) ([694ab9f](694ab9f))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.0 ([#6745](#6745)) ([9c41854](9c41854))
* introduce `aws_s3_bucket_grants` explicit primary key `(bucket_arn, grantee_id)`. If you've previously synced this table you'll need to drop it for the PK change (migration) to succeed. ([cf35801](cf35801))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

2 more reviewers

@candiduslynx candiduslynx candiduslynx approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug(Neo4j): Neo4j Syncs append data into certain tables

4 participants

@bbernays @candiduslynx @yevgenypats @cq-bot