fix: Revert "fix(gcp-resources): Add organization_id and name as PK of gcp_resourcemanager_folders#6576
Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom Jan 10, 2023
Conversation
This PR has the following changes to source plugin(s) tables:
|
Member
|
Can it be, though? Maybe remove the check and see if any weird org ids pop up? |
Member
Author
I'd rather do it separately and fix this bug first as it fails our migration code |
Contributor
|
@erezrokah What if |
…PK of `gcp_resourcemanager_folders` (cloudquery#6547)" This reverts commit 3c0e702.
12cf01a to
6ac8eef
Compare
Member
Author
|
Let's do a full revert of #6547 until we figure this out |
organization_id as PK of gcp_resourcemanager_foldersorganization_id and name as PK of gcp_resourcemanager_folders
organization_id and name as PK of gcp_resourcemanager_foldersorganization_id and name as PK of gcp_resourcemanager_folders
disq
approved these changes
Jan 10, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [6.1.2](plugins-source-gcp-v6.1.1...plugins-source-gcp-v6.1.2) (2023-01-10) ### Bug Fixes * Revert "fix(gcp-resources): Add `organization_id` and `name` as PK of `gcp_resourcemanager_folders` ([#6576](#6576)) ([3434e42](3434e42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looks like
organization_idcan benil.nameshould be good enough:cloudquery/plugins/source/gcp/resources/services/resourcemanager/folders_fetch.go
Line 44 in d904107