fix(gcp-resources)!: Add project_id, instance_name, name as PKs for gcp_bigtableadmin_tables#6536
Merged
erezrokah merged 4 commits intocloudquery:mainfrom Jan 10, 2023
Conversation
…gcp_bigtableadmin_tables
project_id, instance_name, name as PKs for gcp_bigtableadmin_tables`project_id, instance_name, name as PKs for gcp_bigtableadmin_tables
This PR has the following changes to source plugin(s) tables:
|
disq
approved these changes
Jan 9, 2023
yevgenypats
approved these changes
Jan 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [7.0.0](plugins-source-gcp-v6.1.2...plugins-source-gcp-v7.0.0) (2023-01-10) ### ⚠ BREAKING CHANGES * **gcp-resources:** Add `project_id, instance_name, name` as PKs for `gcp_bigtableadmin_tables` ([#6536](#6536)) * **deps:** `gcp_cloudiot_device_configs` column `binary_data` type changed from `IntArray` to `ByteArray` * **deps:** `gcp_cloudiot_device_states` column `binary_data` type changed from `IntArray` to `ByteArray` * **deps:** `gcp_iam_service_account_keys` column `public_key_data` type changed from `IntArray` to `ByteArray` * **deps:** `gcp_run_locations` column `metadata` type changed from `IntArray` to `ByteArray` * **deps:** `gcp_artifactregistry_locations` column `metadata` type changed from `IntArray` to `ByteArray` ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([aa818c5](aa818c5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([aa818c5](aa818c5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([aa818c5](aa818c5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([aa818c5](aa818c5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([aa818c5](aa818c5)) * **gcp-resources:** Add `project_id, instance_name, name` as PKs for `gcp_bigtableadmin_tables` ([#6536](#6536)) ([75cf1c5](75cf1c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcp_bigtableadmin_tableshad onlyproject_idas PK which means we can only get 1 per project inoverwrite*modes.Since the API doesn't provide an Id we need to use the parent
instance_nameand table name.The code to get the table name already exists:
cloudquery/plugins/source/gcp/resources/services/bigtableadmin/tables_fetch.go
Line 28 in 60c0f14
I added it accidentally in #6384.
This is a breaking change as it relies on newly added columns for PKs