fix(destinations): Handle nulls in JSONs#6466
Merged
yevgenypats merged 2 commits intomainfrom Jan 7, 2023
Merged
Conversation
This was referenced Jan 7, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.3](plugins-destination-postgresql-v2.0.2...plugins-destination-postgresql-v2.0.3) (2023-01-07) ### Bug Fixes * **destinations:** Handle nulls in JSONs ([#6466](#6466)) ([f434f00](f434f00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
…re not part of the new schema (#6519) #### Summary Bring back #6282 as the revert was not needed (see the fix #6466). Also I fixed the issue with the tests, they were flaky not failing. The reason is that the separator length is based on the `alter table` statement. Since I use a random table name, I need to pad the table index to make it consistent. **Please note that without this fix, if we rename a primary key column the migration will succeed but the first sync will fail without a clear message on the reason of the failure**. Original issue #6248 <!--
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.2](plugins-destination-neo4j-v1.0.1...plugins-destination-neo4j-v1.0.2) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([#6553](#6553)) ([392b848](392b848)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * **destinations:** Handle nulls in JSONs ([#6466](#6466)) ([f434f00](f434f00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.5](plugins-destination-mongodb-v1.0.4...plugins-destination-mongodb-v1.0.5) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([#6553](#6553)) ([392b848](392b848)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * **destinations:** Handle nulls in JSONs ([#6466](#6466)) ([f434f00](f434f00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we didn't handle
nullswell in all cases.This should close #6333 and also the recent pg report that we got.
Side note: There is some boilerplate code here but I don't think there is a way to avoid it because we do want to give destinations an opportunity to decide what to do on
nullvalue which might not always be just send null as it can be emptystringlike in CSV or some other value.