Merged
Conversation
hermanschaaf
approved these changes
Jan 6, 2023
not null columns that are not part of the new schema"
Contributor
Author
|
Also closes #6433 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.2](plugins-destination-postgresql-v2.0.1...plugins-destination-postgresql-v2.0.2) (2023-01-06) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * Error if after the migration there are `not null` columns that are not part of the new schema ([#6282](#6282)) ([c5a4bf5](c5a4bf5)) * **pg:** Return more detailed pg errors ([#6421](#6421)) ([acb3e21](acb3e21)) * **postgresql:** Revert [#6282](#6282) ([#6434](#6434)) ([2cecacd](2cecacd)) * **tests:** Postgresql: Read only columns defined in the schema ([#6371](#6371)) ([491941a](491941a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
to erezrokah/cloudquery
that referenced
this pull request
Jan 9, 2023
This reverts commit 2cecacd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should be given additional take, potentially not doing any drops as we should avoid those like fire especially when running those in distributed mode and so on.