Skip to content

fix: Fix SQLite migration logic#6372

Merged
kodiakhq[bot] merged 2 commits intomainfrom
sqlite-migrate
Jan 5, 2023
Merged

fix: Fix SQLite migration logic#6372
kodiakhq[bot] merged 2 commits intomainfrom
sqlite-migrate

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

There was a bug in the query that checks whether a table exists - it always found the table to not exist because ? was being quoted. We also now select only the columns defined in the table schema, rather than all columns.

This will allow https://github.com/cloudquery/plugin-sdk/pull/574/files to pass.

@hermanschaaf hermanschaaf requested review from a team and disq and removed request for a team January 5, 2023 11:18
@cq-bot cq-bot added the sqlite label Jan 5, 2023
@hermanschaaf hermanschaaf added the automerge Automatically merge once required checks pass label Jan 5, 2023
@kodiakhq kodiakhq bot merged commit 5f8a197 into main Jan 5, 2023
@kodiakhq kodiakhq bot deleted the sqlite-migrate branch January 5, 2023 14:32
kodiakhq bot pushed a commit that referenced this pull request Jan 10, 2023
🤖 I have created a release *beep* *boop*
---


## [1.1.4](plugins-destination-sqlite-v1.1.3...plugins-destination-sqlite-v1.1.4) (2023-01-10)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([#6553](#6553)) ([392b848](392b848))
* **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f))
* Fix SQLite migration logic ([#6372](#6372)) ([5f8a197](5f8a197))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants