feat: Oracle plugin#6353
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 12, 2023
shimonp21:feat_oci_plugin
Merged
feat: Oracle plugin#6353kodiakhq[bot] merged 2 commits intocloudquery:mainfrom shimonp21:feat_oci_plugin
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:feat_oci_plugin
Conversation
This PR has the following changes to source plugin(s) tables:
|
yevgenypats
suggested changes
Jan 5, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Let's remove the codegen and use built-in plugin-sdk transformations instead . will be easier for my to review 2,000 LOCs lines instead of 19,082 LOCs.
hermanschaaf
reviewed
Jan 9, 2023
yevgenypats
approved these changes
Jan 11, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
It looks good. Caveat: I didn't have a chance to run this with a proper Oracle account and test if the spec and multiplexers make the most sense. If it get's more traction we can fine-tune it later.
shimonp21
pushed a commit
that referenced
this pull request
Jan 17, 2023
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-01-17) ### Features * Oracle plugin ([#6353](#6353)) ([740a428](740a428)) ### Bug Fixes * Add oracle goreleaser ([#6838](#6838)) ([7ec3abd](7ec3abd)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of oracle plugin. See more information below.
TODOs:
mysqlandnosqlresources make the plugin get stuck.codegen/main.goservicesAllowlistandservicesDenylistto generate more resources.oracle_volumes->size_in_m_bs)Codegen explanation:
codegengenerates table-definitions and fetcher-functions, based onoracle_clients.go.oracle_clientswas semi-manually generated by me using the scriptgenerate_oracleClients_struct.py.generate_oracleClients_struct.pyrequires cloning [https://github.com/oracle/oci-go-sdk] and running the [pkgreflect] tool on it.