fix: Return error if read is called when no_rotate is false#6263
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jan 3, 2023
Merged
fix: Return error if read is called when no_rotate is false#6263kodiakhq[bot] merged 2 commits intomainfrom
no_rotate is false#6263kodiakhq[bot] merged 2 commits intomainfrom
Conversation
1ea3a64 to
7a2989a
Compare
7a2989a to
e865ba9
Compare
yevgenypats
approved these changes
Jan 3, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jan 3, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.2](plugins-destination-azblob-v1.0.1...plugins-destination-azblob-v1.0.2) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/cloudquery/filetypes to v1.0.2 ([#6340](#6340)) ([d0d867b](d0d867b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.3 ([#6523](#6523)) ([5378f3b](5378f3b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.4 ([#6565](#6565)) ([80c7c06](80c7c06)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * Return error if read is called when `no_rotate` is false ([#6263](#6263)) ([c475be7](c475be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.3](plugins-destination-s3-v1.0.2...plugins-destination-s3-v1.0.3) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.8 ([#6393](#6393)) ([ffba44f](ffba44f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.47 ([#6395](#6395)) ([71ec9b9](71ec9b9)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.2 ([#6340](#6340)) ([d0d867b](d0d867b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.3 ([#6523](#6523)) ([5378f3b](5378f3b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.4 ([#6565](#6565)) ([80c7c06](80c7c06)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * Return error if read is called when `no_rotate` is false ([#6263](#6263)) ([c475be7](c475be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.3](plugins-destination-gcs-v1.0.2...plugins-destination-gcs-v1.0.3) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/cloudquery/filetypes to v1.0.2 ([#6340](#6340)) ([d0d867b](d0d867b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.3 ([#6523](#6523)) ([5378f3b](5378f3b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.4 ([#6565](#6565)) ([80c7c06](80c7c06)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * Return error if read is called when `no_rotate` is false ([#6263](#6263)) ([c475be7](c475be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.3](plugins-destination-file-v1.0.2...plugins-destination-file-v1.0.3) (2023-01-10) ### Bug Fixes * **deps:** Update module github.com/cloudquery/filetypes to v1.0.2 ([#6340](#6340)) ([d0d867b](d0d867b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.3 ([#6523](#6523)) ([5378f3b](5378f3b)) * **deps:** Update module github.com/cloudquery/filetypes to v1.0.4 ([#6565](#6565)) ([80c7c06](80c7c06)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d)) * **deps:** Update plugin-sdk to v1.21.0 for destinations ([#6419](#6419)) ([f3b989f](f3b989f)) * Return error if read is called when `no_rotate` is false ([#6263](#6263)) ([c475be7](c475be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same as #6262 not from a fork
We should return an error when trying to read if
no_rotateisfalseas we can't read a randomly generated name