fix(bigquery-spec)!: Move batch_size from the plugin spec to the top level spec#6090
Closed
erezrokah wants to merge 2 commits intocloudquery:mainfrom
Closed
fix(bigquery-spec)!: Move batch_size from the plugin spec to the top level spec#6090erezrokah wants to merge 2 commits intocloudquery:mainfrom
batch_size from the plugin spec to the top level spec#6090erezrokah wants to merge 2 commits intocloudquery:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erezrokah
added a commit
that referenced
this pull request
Dec 29, 2022
…p level spec (#6092) <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Same as #6090 not from a fork so tests can pass. Fixes #6070 With the SDK level batching the configuration that "takes" is now at the top spec level. Setting `batch_size` at the plugin level has no impact <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Test locally on your own infrastructure - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #6070 (comment).
With the SDK level batching the configuration that "takes" is now at the top spec level. Setting
batch_sizeat the plugin level has no impact