refactor(gcp-codegen): Extract generateTemplate method#5958
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 3, 2023
Merged
refactor(gcp-codegen): Extract generateTemplate method#5958kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
Collaborator
|
@erezrokah - I have ideas about how to do this if you want me to work on it today |
Member
Author
Opened a PR in #5961 |
defee7b to
0ab4046
Compare
0ab4046 to
9330274
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yevgenypats
approved these changes
Jan 3, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
#### Summary Fixes #5957. We need to put the services file in both the code gen module and the GCP client as they both use it. Previously code gen referenced the GCP client directly which prevents auto generation of the services file. It should be easier to review this once #5958 is merged. Added a new makefile target as we should first discover the services, then run the codegen <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts
generateTemplateinto a separate method to reduce code duplication.This should make it easier to implement #5957