feat: Add instance_view to azure_compute_virtual_machines table#5941
Merged
kodiakhq[bot] merged 11 commits intomainfrom Dec 25, 2022
Merged
feat: Add instance_view to azure_compute_virtual_machines table#5941kodiakhq[bot] merged 11 commits intomainfrom
kodiakhq[bot] merged 11 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR has the following changes to source plugin(s) tables:
|
erezrokah
approved these changes
Dec 25, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, but maybe we can remove the commented out code
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](plugins-source-azure-v2.2.0...plugins-source-azure-v3.0.0) (2022-12-27) ### ⚠ BREAKING CHANGES * **azure:** Rename e_tag to etag ([#5902](#5902)) ### Features * Add instance_view to azure_compute_virtual_machines table ([#5941](#5941)) ([d65d80f](d65d80f)) * **azure:** Add search,logic,monitor,redis tables ([#5952](#5952)) ([9e16822](9e16822)) ### Bug Fixes * **azure:** Rename e_tag to etag ([#5902](#5902)) ([3c9daf5](3c9daf5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.13.1 ([#5897](#5897)) ([ad15915](ad15915)) * Update Azure auto provisioning queries ([#5888](#5888)) ([cf838ed](cf838ed)) * Update Azure Storage Queries ([#5908](#5908)) ([38690c6](38690c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently
az vm listalways returns instance_views column as empty so to get that data we need additional call.