Skip to content

feat(aws)!: Refactor SES#5802

Merged
kodiakhq[bot] merged 2 commits intomainfrom
feat/aws/ses/refactor
Dec 19, 2022
Merged

feat(aws)!: Refactor SES#5802
kodiakhq[bot] merged 2 commits intomainfrom
feat/aws/ses/refactor

Conversation

@candiduslynx
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx commented Dec 19, 2022 •
edited by erezrokah
Loading

Summary

Added ARN to aws_ses_identies based on documentation (changes PK)

BEGIN_COMMIT_OVERRIDE
feat(aws): Add arn to aws_ses_identies

BREAKING CHANGE: The primary key for the aws_ses_identies table is now arn instead of account_id , name and region.
END_COMMIT_OVERRIDE

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2022 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table aws_ses_configuration_set_event_destinations: column order changed for name
  • Table aws_ses_configuration_sets: column added with name arn (PK) and type String
  • Table aws_ses_configuration_sets: primary key constraint removed from column account_id
  • Table aws_ses_configuration_sets: primary key constraint removed from column name
  • Table aws_ses_configuration_sets: primary key constraint removed from column region

@candiduslynx candiduslynx requested review from erezrokah and removed request for hermanschaaf and yevgenypats December 19, 2022 13:45
@candiduslynx candiduslynx self-assigned this Dec 19, 2022
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Dec 19, 2022
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cloudquery-web 🔄 Building (Inspect) Dec 19, 2022 at 1:48PM (UTC)

erezrokah
erezrokah approved these changes Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the follow up. I added a detailed changelog message in the PR description

@kodiakhq kodiakhq bot merged commit 6338855 into main Dec 19, 2022
@kodiakhq kodiakhq bot deleted the feat/aws/ses/refactor branch December 19, 2022 14:01
@candiduslynx candiduslynx mentioned this pull request Dec 19, 2022
Merged
@erezrokah erezrokah mentioned this pull request Dec 22, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 22, 2022
@erezrokah
feat(table-diff): Mark newly added PKs as breaking changes (#5909)
26cbd1f 

#### Summary

A small addition to the table diff comment, to mark newly added PKs as breaking changes (related to #5802 (comment))

<!--
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees

@candiduslynx candiduslynx

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@candiduslynx @erezrokah @cq-bot