Skip to content

fix(gcp): Remove error wrapping#5654

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:fix/remove_error_wrapping
Dec 15, 2022
Merged

fix(gcp): Remove error wrapping#5654
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:fix/remove_error_wrapping

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Dec 14, 2022

Summary

This is not needed anymore I think

@cq-bot cq-bot added the gcp label Dec 14, 2022
@erezrokah erezrokah added automerge Automatically merge once required checks pass and removed gcp labels Dec 14, 2022
@cq-bot cq-bot added the gcp label Dec 14, 2022
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove this from go.mod

@kodiakhq kodiakhq bot merged commit c2b4295 into cloudquery:main Dec 15, 2022
kodiakhq bot pushed a commit that referenced this pull request Dec 15, 2022

#### Summary

Follow up to #5654, missed a find replace and also does #5654 (review)

<!--
kodiakhq bot pushed a commit that referenced this pull request Dec 20, 2022
🤖 I have created a release *beep* *boop*
---


## [5.1.2](plugins-source-gcp-v5.1.1...plugins-source-gcp-v5.1.2) (2022-12-20)


### Bug Fixes

* **deps:** Migrate GCP to new proto imports ([#5803](#5803)) ([78e8ab6](78e8ab6))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.5 ([#5661](#5661)) ([b354b8a](b354b8a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.6 ([#5790](#5790)) ([8e2663c](8e2663c))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.7 ([#5797](#5797)) ([15da529](15da529))
* **gcp-resources:** Add `projects/` prefix when listing IAM roles ([#5655](#5655)) ([23711be](23711be))
* **gcp:** Remove error wrapping ([#5654](#5654)) ([c2b4295](c2b4295))
* **gcp:** Remove error wrapping ([#5669](#5669)) ([721e588](721e588))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants