chore: Remove pre-commit files and make targets#5559
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Dec 12, 2022
Merged
chore: Remove pre-commit files and make targets#5559kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
yevgenypats
approved these changes
Dec 12, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Oh nice, was about to ask for that. 🚀
disq
added a commit
to disq/cloudquery
that referenced
this pull request
Dec 12, 2022
disq
added a commit
to disq/cloudquery
that referenced
this pull request
Dec 14, 2022
disq
added a commit
to disq/cloudquery
that referenced
this pull request
Dec 14, 2022
This was referenced Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commitdoesn't really works in monorepos (at least how we configured it). We need to do some fancy stuff to configure it, see pre-commit/pre-commit#466 and I think this will mean we will run lint on all plugins onpre-commit