feat: Add more cases where DateTime types in CSV responses of AWS IAM…#5526
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Dec 9, 2022
CC11001100:main
Merged
feat: Add more cases where DateTime types in CSV responses of AWS IAM…#5526kodiakhq[bot] merged 2 commits intocloudquery:mainfrom CC11001100:main
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
CC11001100:main
Conversation
… may have illegal values
hermanschaaf
approved these changes
Dec 9, 2022
Contributor
|
Thanks for this fix @CC11001100 ! |
Contributor
|
It feels like we should be storing this column as a string (so that this information is not lost), but that's a bigger change, I'm happy with this for now. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
🤖 I have created a release *beep* *boop* --- ## [7.4.0](plugins-source-aws-v7.3.2...plugins-source-aws-v7.4.0) (2022-12-13) ### Features * Add more cases where DateTime types in CSV responses of AWS IAM… ([#5526](#5526)) ([a43bf39](a43bf39)) * **aws:** Add IAM SSH Public Keys ([#5538](#5538)) ([5bd2b4d](5bd2b4d)) ### Bug Fixes * **aws-functions:** Return error in case of access denied ([#5537](#5537)) ([1fe79d3](1fe79d3)) * **aws:** Deterministic Multiplexer ([#5513](#5513)) ([eaf6e99](eaf6e99)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/appstream to v1.18.2 ([#5566](#5566)) ([e7b7c24](e7b7c24)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/athena to v1.20.2 ([#5523](#5523)) ([9385a69](9385a69)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.25.0 ([#5524](#5524)) ([5009a35](5009a35)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.17.2 ([#5535](#5535)) ([2ce06fc](2ce06fc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.76.0 ([#5569](#5569)) ([979a780](979a780)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/mq to v1.13.17 ([#5567](#5567)) ([6075e71](6075e71)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/rds to v1.34.0 ([#5570](#5570)) ([8fd69ba](8fd69ba)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafv2 to v1.23.3 ([#5568](#5568)) ([1782f00](1782f00)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.0 ([#5539](#5539)) ([fb71293](fb71293)) * Update endpoints ([#5520](#5520)) ([88a88a7](88a88a7)) * Update endpoints ([#5565](#5565)) ([6b8c15d](6b8c15d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deserialization of CSV by iam in resource under
cloudquery-aws-providerdoes not cover all cases, which may lead to wrong data pull out. For details, we can read the official AWS documents, as mentioned in this document:This is also mentioned in another document:
To sum up, we should add the case
no_information:Please review my code, thank you