fix(gcp): Fix context to work when syncing#5512
Merged
kodiakhq[bot] merged 6 commits intomainfrom Dec 8, 2022
Merged
Conversation
Also, make mocks and codegen easier with learnings from Azure
Closed
hermanschaaf
reviewed
Dec 8, 2022
hermanschaaf
approved these changes
Dec 8, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
The fix makes sense to me, and I spot-checked a few resources - looks good, but I didn't go through it line by line :)
plugins/source/gcp/client/client.go
Outdated
| ClientOptions []option.ClientOption | ||
| // All gcp services initialized by client | ||
| Services *Services | ||
| // Services *Services |
Contributor
There was a problem hiding this comment.
Nit: let's completely remove this
Contributor
There was a problem hiding this comment.
Is the Services struct still used anywhere after this? Can it be removed? (I don't have the code checked out locally right now to check)
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-source-gcp-v3.2.0...plugins-source-gcp-v4.0.0) (2022-12-13) ### ⚠ BREAKING CHANGES * **gcp:** Only list enabled Services ([#5557](#5557)) * **gcp:** Only List Project Roles ([#5556](#5556)) * **gcp:** `private_key_type` column was removed from the `gcp_iam_service_account_keys` table as it was always populated with `nil`. If you were using it in one of your queries, you can safely remove it. ### Features * **gcp:** Add retrier ([#5522](#5522)) ([bf8c212](bf8c212)), closes [#5514](#5514) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.11.1 ([#5458](#5458)) ([58b7432](58b7432)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.11.2 ([#5497](#5497)) ([c1876cf](c1876cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.0 ([#5539](#5539)) ([fb71293](fb71293)) * **gcp:** Fix context to work when syncing ([#5512](#5512)) ([81c8075](81c8075)) * **gcp:** Only list enabled Services ([#5557](#5557)) ([5310bef](5310bef)) * **gcp:** Only List Project Roles ([#5556](#5556)) ([51acb48](51acb48)) * **gcp:** Remove `private_key_type` column from `gcp_iam_service_account_keys` ([1371928](1371928)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems
ctxnever worked given thatctxis passed on creation and not on call.Also, this takes some learning from azure and makes code generation easier.
For context there is no need for
servicesanymore and we can create and close the server in thetesting.gohelper function instead of doing this in every single mock function