Skip to content

fix: Policy describe should run without config.hcl requirement#546

Merged
zagronitay merged 5 commits intocloudquery:mainfrom
zagronitay:fix/remove-policy-describe-config.hcl-requirement
Mar 28, 2022
Merged

fix: Policy describe should run without config.hcl requirement#546
zagronitay merged 5 commits intocloudquery:mainfrom
zagronitay:fix/remove-policy-describe-config.hcl-requirement

Conversation

@zagronitay
Copy link
Copy Markdown
Contributor

No description provided.

@zagronitay zagronitay requested review from a team and irmatov and removed request for a team March 21, 2022 16:08
@zagronitay zagronitay requested review from bbernays, disq and roneli March 21, 2022 16:08
@github-actions github-actions bot added the fix label Mar 21, 2022
@disq
Copy link
Copy Markdown
Member

disq commented Mar 21, 2022

Yes but only if the cq files are under .cq. It won't work if you have them somewhere else because you can't provide config.hcl if you wanted to now. You're locked into the null client.

Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one nit.

@zagronitay zagronitay merged commit 9bad3eb into cloudquery:main Mar 28, 2022
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Mar 29, 2022
* upstream/main:
  chore: Update SDK (cloudquery#557)
  feat: Drift: List unimplemented resources in debug mode (cloudquery#558)
  fix: Policy describe should run without config.hcl requirement (cloudquery#546)
  feat: Limit scope of views (cloudquery#556)
  feat: Simplify fetch warning/error counts (unless -v is on) (cloudquery#554)
  fix: Add ProviderVersion to the 'cloudquery.fetches' meta table (cloudquery#555)
  chore: Sync from .github (cloudquery#553)
  feat: Added checking of finished fetches before running policy (cloudquery#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove requirement for config.hcl when running cloudquery policy describe

3 participants