fix: Prevent concurrent map read & write in snowflake write function#5452
Merged
kodiakhq[bot] merged 2 commits intomainfrom Dec 7, 2022
Merged
fix: Prevent concurrent map read & write in snowflake write function#5452kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
yevgenypats
approved these changes
Dec 6, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. I think I need to update the destination plugin API to always batch by tables. This will simplify the implementation for all destination plugins. Also, this will solve the annoying thing on PostgreSQL and other destination where we can't know which table caused the error 😆
erezrokah
approved these changes
Dec 7, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.5](plugins-destination-snowflake-v1.0.4...plugins-destination-snowflake-v1.0.5) (2022-12-07) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.11.1 ([#5458](#5458)) ([58b7432](58b7432)) * Prevent concurrent map read & write in snowflake write function ([#5452](#5452)) ([a6a74de](a6a74de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens rarely, but sometimes the
workersmap gets accessed by the goroutine while the loop is still writing to the map, which causes a panic.