Skip to content

fix: Handling of NULL bytes in Postgresql Text fields#5249

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:fix_transformer_error_handling
Dec 1, 2022
Merged

fix: Handling of NULL bytes in Postgresql Text fields#5249
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:fix_transformer_error_handling

Conversation

@shimonp21
Copy link
Copy Markdown
Contributor

@shimonp21 shimonp21 commented Dec 1, 2022

Required to fix batch-write-failures due to postgresql TEXT fields containing NULL bytes.

2022-11-30T12:00:11Z ERR failed to execute batch with pgerror error="ERROR: invalid byte sequence for encoding \"UTF8\": 0x00 (SQLSTATE 22021)" module=pg-dest

@cq-bot cq-bot added the sqlite label Dec 1, 2022
@shimonp21 shimonp21 requested a review from yevgenypats December 1, 2022 10:10
@shimonp21 shimonp21 marked this pull request as ready for review December 1, 2022 10:10
@shimonp21 shimonp21 requested a review from a team December 1, 2022 10:10
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some performance nit

@shimonp21 shimonp21 requested a review from yevgenypats December 1, 2022 12:16
@shimonp21 shimonp21 added the automerge Automatically merge once required checks pass label Dec 1, 2022
@kodiakhq kodiakhq bot merged commit 936c311 into cloudquery:main Dec 1, 2022
shimonp21 pushed a commit that referenced this pull request Dec 1, 2022
🤖 I have created a release *beep* *boop*
---


##
[1.7.16](plugins-destination-postgresql-v1.7.15...plugins-destination-postgresql-v1.7.16)
(2022-12-01)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.10.0
([#5153](#5153))
([ea1f77e](ea1f77e))
* Handling of NULL bytes in Postgresql Text fields
([#5249](#5249))
([936c311](936c311))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Dec 1, 2022
🤖 I have created a release *beep* *boop*
---


## [1.0.11](plugins-destination-sqlite-v1.0.10...plugins-destination-sqlite-v1.0.11) (2022-12-01)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.10.0 ([#5153](#5153)) ([ea1f77e](ea1f77e))
* Handling of NULL bytes in Postgresql Text fields ([#5249](#5249)) ([936c311](936c311))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants